Don’t clone node in handleRawHtml()
#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don’t know why the code cloned the node before modifying it – there’s no explanation of this in #2, and the rest of the code is happy to modify nodes directly. However, this causes attribute binding on nodes with v-html to have no effect – after handleRawHtml(), the original node is skipped for further processing (isRemovedFromTheDom() returns true), and even if it wasn’t, handling attributes on it wouldn’t have any effect on the node that’s actually in the DOM now. Given that removing the cloning doesn’t seem to break any tests, let’s just remove it and add a test for attribute binding in conjunction with v-html. Bug: T396633 Bug: T396634
codders
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don’t know why the code cloned the node before modifying it – there’s no explanation of this in #2, and the rest of the code is happy to modify nodes directly. However, this causes attribute binding on nodes with
v-htmlto have no effect – afterhandleRawHtml(), the original node is skipped for further processing (isRemovedFromTheDom()returns true), and even if it wasn’t, handling attributes on it wouldn’t have any effect on the node that’s actually in the DOM now. Given that removing the cloning doesn’t seem to break any tests, let’s just remove it and add a test for attribute binding in conjunction withv-html.Bug: T396633
Bug: T396634