Skip to content

Support non-utf8 request params in Req.Test #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support non-utf8 request params in Req.Test #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/req/steps.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,7 @@ defmodule Req.Steps do
conn =
Req.Test.Adapter.conn(%Plug.Conn{}, request.method, request.url, req_body)
|> Map.replace!(:req_headers, req_headers)
|> Plug.Conn.fetch_query_params()
|> Plug.Conn.fetch_query_params(validate_utf8: false)
|> Plug.Parsers.call(parser_opts)

# Handle cases where the body isn't read with Plug.Parsers
Expand Down
3 changes: 2 additions & 1 deletion test/req/steps_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,10 +1875,11 @@ defmodule Req.StepsTest do
plug = fn conn ->
{:ok, body, conn} = Plug.Conn.read_body(conn)
assert body == ~s|{"a":1}|
assert conn.query_params == %{"foo" => <<0xFF>>}
Plug.Conn.send_resp(conn, 200, "ok")
end

assert Req.request!(plug: plug, json: %{a: 1}).body == "ok"
assert Req.request!(plug: plug, json: %{a: 1}, params: %{foo: <<0xFF>>}).body == "ok"
refute_receive _
end

Expand Down