Add GitHub warning to constraint layout dependency updates #14473
Conversation
malinajirka
added
the
category: tooling
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
👋 @malinajirka , thanks for this, I just reviewed, vibe-reviewed it too, and it all LGTM, it should work as expected, let's merge this and see, worse-case we quickly revert it! 🙇 ❤️ 🚀
FYI: After merging this, we could (potentially) re-open this #14400 PR and see it working, right... 🤞
I noticed it uses github-script@v7 while we use v4 in the other scripts - not sure if that's fine or not, but according to Claude v7 should be more secure.
👍
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a GitHub Actions workflow to automatically warn about potential POS (Point of Sale) system issues when Dependabot creates pull requests that update the androidx.constraintlayout:constraintlayout-compose dependency. The workflow is triggered by Dependabot PRs and posts a comment with testing requirements when the specific dependency is being updated.
- Adds automated detection of constraintlayout-compose dependency updates in Dependabot PRs
- Creates warning comments with specific POS testing checklist
- Implements duplicate comment prevention logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ); | ||
|
|
||
| if (!botComment) { | ||
| const commentBody = `## ⚠️ POS Testing Required |
There was a problem hiding this comment.
The multi-line template literal has inconsistent indentation. The content should be aligned with the opening backtick or use consistent indentation throughout the string.
Copilot uses AI. Check for mistakes.
Great idea! |
malinajirka
deleted the
issue/woomob-1047-dependabot-github-action-with-warning-about-constraint
branch
This PR adds a github action that should drop a comment/warning on PRs created by dependabot that update the constraintlayout-compose dependency. We found out that the new version breaks the POS, specifically the items in the cart start disappearing during screen transitions.
The code was vibe coded and hasn't been tested. I've checked it and it looks fine.
I noticed it uses github-script@v7 while we use v4 in the other scripts - not sure if that's fine or not, but according to Claude v7 should be more secure.
Let me know what you think, thanks!