-
Notifications
You must be signed in to change notification settings - Fork 134
[Shipping Labels] Improvements to the Customs Form screen #14477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping Labels] Improvements to the Customs Form screen #14477
Conversation
We were passing the Composable `modifier` to all childs.
Generated by 🚫 Danger |
WooThemeWithBackground { | ||
Surface { | ||
WooShippingCustomsFormScreen(viewModel = viewModel) | ||
CompositionLocalProvider(LocalUriHandler provides chromeTabUriHandler) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For simplicity, I opted to use LocalUriHandler
, this allows us to not add more callbacks to the Compose
function that already has too many callbacks, but on the other hand this means the ViewModel is not involved here, and we can't unit test this. Personally I think it's fine, but please let me know if you don't agree.
Also, I'm using a custom UriHandler
here to use a Chrome custom tab instead of opening the URLs in external browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #14477 +/- ##
============================================
- Coverage 37.97% 37.94% -0.04%
Complexity 9261 9261
============================================
Files 2004 2004
Lines 112748 112849 +101
Branches 14887 14910 +23
============================================
- Hits 42819 42818 -1
- Misses 66018 66120 +102
Partials 3911 3911 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ce/android/ui/orders/wooshippinglabels/customs/products/WooShippingCustomsProductListItem.kt
Show resolved
Hide resolved
Thanks @irfano, ready for another round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Hicham! LGTM! 🚢
c650a65
to
b4a9d0b
Compare
Closes WOOMOB-878
Description
This PR adds the following improvements to the Customs Form screen:
Note
For the description field, as we are using the material outlined text field, showing the info button next to the label like what we have in Figma and what iOS does is not possible, I instead opted to have it inlined in the end, let me know what you think.
Steps to reproduce
Testing information
The tests that have been performed
The above.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.