fix: auto icons override default icons

[omerfardemir]

just removed return statement in line 35.

wxt/packages/auto-icons/src/index.ts

Line 35 in 31071bd

return wxt.logger.warn(

Manual Testing

1. have default icons in the public folder public/icon/*
2. install auto icons
3. add a icon to <src>/assets/icon.png
4. run npm run dev

This PR closes #1592

[netlify]

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	2dabfec
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/683c1a86fdf06100085aa134
😎 Deploy Preview	https://deploy-preview-1616--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Timeraa]

Could you add a test for this?

[omerfardemir]

I added tests and here is output:

✓ src/__test__/index.test.ts (9 tests) 23ms
   ✓ auto-icons module > options handling > should use default options when not provided 5ms
   ✓ auto-icons module > options handling > should merge custom options with defaults 1ms
   ✓ auto-icons module > error handling > should warn when disabled 4ms
   ✓ auto-icons module > error handling > should warn when base icon not found 1ms
   ✓ auto-icons module > manifest generation > should update manifest with icons 2ms
   ✓ auto-icons module > manifest generation > should warn when overwriting existing icons in manifest 1ms
   ✓ auto-icons module > icon generation > should generate icons with correct sizes 2ms
   ✓ auto-icons module > icon generation > should apply grayscale in development mode but not in production 1ms
   ✓ auto-icons module > public paths > should add icon paths to public paths 1ms

 Test Files  1 passed (1)
      Tests  9 passed (9)
   Start at  00:40:30
   Duration  630ms (transform 35ms, setup 0ms, collect 84ms, tests 23ms, environment 0ms, prepare 185ms)

[Timeraa]

Thank you, did I not add any tests to that module when I made it? Oopsies haha.

Looks all fine from me so @aklinker1 can merge when he approves of it

[aklinker1]

I'm alive! Been busy with some other life stuff. Should be back on GitHub and discord soon.

[aklinker1]

These tests don't import or test the actual module's logic, it just copies some code into the test file.

I can help write tests that import and use the actual module... Sometime soon 🤞

[omerfardemir]

@aklinker1 Actually, I checked all the modules but I couldn't find an example that imports and tests a module. I also checked the Unit Test documention but I couldn't find the answer I was looking for. If you give me a clue, I'd be happy to improve it. Thanks for your time 😊

[Timeraa]

I'm alive! Been busy with some other life stuff. Should be back on GitHub and discord soon.

No worries everyone gets through things like that in life sometimes! I'm currently going through a lot of it as well