Various fixes #170
Open
Various fixes #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run formater on extension.ts Signed-off-by: Jesse Taube <[email protected]>
Add the ability to use
${workspaceRoot}
${workspaceFolder}
${cwd}
${env.VAR}
in the .clang-format path
Signed-off-by: Jesse Taube <[email protected]>
Fix most of the variables should be const. Remove unused variables. Move many declarations to the top of the function. Signed-off-by: Jesse Taube <[email protected]>
`vscode.workspace.getConfiguration('clang-format')` is called in
almost every function often multiple times. This commit adds
`const config = ...` at the top of each function to reduce repetition.
Signed-off-by: Jesse Taube <[email protected]>
If vscode has no workspace the extension will fail. Check if the styles are valid before using them. Signed-off-by: Jesse Taube <[email protected]>
Some users may want to pass additional arguments to clang-format. This commit adds a setting to allow users to do so. Signed-off-by: Jesse Taube <[email protected]>
|
Hey, can you tell me how to install this branch of the plugin inside vscode? |
|
@xavgru12 there is an updated version here that has these changes and more: https://github.com/somethingsoftware/vscode-clang-format https://marketplace.visualstudio.com/items?itemName=Something-Software.clang-format-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.