Skip to content

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues comma-separated list of tickets # fixed by the PR, if any

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix tests

@rustamwin rustamwin requested a review from a team July 28, 2025 10:08
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍

"yiisoft/widget": "^2.2",
"yiisoft/yii-console": "^2.3",
"yiisoft/yii-cycle": "^1.0",
"yiisoft/yii-cycle": "dev-master as 1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to tag changes in master instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting yiisoft/yii-cycle#228 and release.

@samdark samdark requested a review from vjik July 28, 2025 10:40
@samdark
Copy link
Member

samdark commented Jul 28, 2025

@rustamwin please fix calling Timer::end() in tests.

@rustamwin
Copy link
Member Author

rustamwin commented Jul 28, 2025

@rustamwin please fix calling Timer::end() in tests.

There is no Timer::end().

@samdark samdark merged commit 78e6adf into master Jul 29, 2025
11 checks passed
@samdark samdark deleted the update-deps branch July 29, 2025 17:41
@samdark
Copy link
Member

samdark commented Jul 29, 2025

👍 Let's update tags to stable when dependencies will be tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants