Skip to content

Fix type hint for previous parameter in InvalidJobException class constructor. #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2025
Merged

Fix type hint for previous parameter in InvalidJobException class constructor. #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ab6a14
Fix type hint for previous parameter in `InvalidJobException` class c…
terabytesoftw Aug 6, 2025
cf89673
Update Dockerfile for `PHP 7.1` and `7.2` to include Debian archive s…
terabytesoftw Aug 11, 2025
b413547
Add line to `CHANGELOG.md`.
terabytesoftw Aug 11, 2025
ebec17b
Fix `CHANGELOG.md`.
terabytesoftw Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Yii2 Queue Extension Change Log
- Bug #522: Fix SQS driver type error with custom value passed to `queue/listen` (flaviovs)
- Bug #528: Prevent multiple execution of aborted jobs (luke-)
- Enh #493: Pass environment variables to sub-processes (mgrechanik)
- Bug #538: Fix type hint for previous parameter in `InvalidJobException` class constructor in PHP `8.4` (implicitly marking parameter nullable) (terabytesoftw)

2.3.7 April 29, 2024
--------------------
Expand Down
2 changes: 1 addition & 1 deletion src/InvalidJobException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class InvalidJobException extends \Exception
* @param int $code
* @param Throwable|null $previous
*/
public function __construct($serialized, $message = '', $code = 0, Throwable $previous = null)
public function __construct($serialized, $message = '', $code = 0, $previous = null)
{
$this->serialized = $serialized;
parent::__construct($message, $code, $previous);
Expand Down
4 changes: 3 additions & 1 deletion tests/docker/php/7.1/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
FROM php:7.1-cli

RUN apt-get update \
RUN echo "deb http://archive.debian.org/debian buster main contrib non-free" > /etc/apt/sources.list \
&& echo "deb http://archive.debian.org/debian-security buster/updates main contrib non-free" >> /etc/apt/sources.list \
&& apt-get update --allow-releaseinfo-change \
&& apt-get install -y unzip curl zlib1g-dev libicu-dev libpq-dev libgearman-dev

RUN docker-php-ext-install zip pcntl bcmath pdo_mysql intl pdo_pgsql
Expand Down
6 changes: 4 additions & 2 deletions tests/docker/php/7.2/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM php:7.2-cli

RUN apt-get update \
&& apt-get install -y unzip libbz2-dev curl zlib1g-dev libicu-dev libpq-dev libgearman-dev
RUN echo "deb http://archive.debian.org/debian buster main contrib non-free" > /etc/apt/sources.list \
&& echo "deb http://archive.debian.org/debian-security buster/updates main contrib non-free" >> /etc/apt/sources.list \
&& apt-get update --allow-releaseinfo-change \
&& apt-get install -y unzip curl zlib1g-dev libicu-dev libpq-dev libgearman-dev

RUN docker-php-ext-install zip pcntl bcmath pdo_mysql intl pdo_pgsql

Expand Down