17 add support for streamable http transport #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(rails integration): documentation + railtie * doc(rails): add a demo app * 🔨fix tests + convert some verbose logs to :debug * Delete engine.rb * Delete README * 📚 start working on documentation * Rename MCP to FastMcp * 🧹 cleanup dead code + fix authenticated rack transport * 🔨fix module name in version * Update Gemfile.lock * Update version.rb * 🧪 fix rack transport test * Update Gemfile * 🤖 Automate Github releases on tag creations * Update CHANGELOG.md
zalom
reviewed
Apr 13, 2025
Comment on lines
+13
to
+14
| #{app.root}/app/tools | ||
| #{app.root}/app/resources |
There was a problem hiding this comment.
Does it make sense to scope by mcp or fast_mcp namespace?
eg.
Suggested change
| #{app.root}/app/tools | |
| #{app.root}/app/resources | |
| #{app.root}/app/fast_mcp/tools | |
| #{app.root}/app/fast_mcp/resources |
The app folder tends to be polluted (for big projects), and tools and resources are such common concepts.
app/lib/mcp works too.
There was a problem hiding this comment.
For greenfield projects, autoloading of anything in app folder works automagically (with Zeitwerk). Even for brownfield projects, as of Rails 6, the Zeitwerk is the default autoloader.
zalom
reviewed
Apr 13, 2025
| def add(severity, message = nil, progname = nil, &block) | ||
| return if stdio_transport? # we don't want to log to stdout if we're using the stdio transport | ||
|
|
||
| # TODO: implement logging as the specification requires |
There was a problem hiding this comment.
Suggested change
| # TODO: implement logging as the specification requires | |
| # TODO: implement logging as the specification requires | |
| # https://modelcontextprotocol.io/specification/2025-03-26/server/utilities/logging |
|
Thank you for your work, mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened as #19,
Work in Progress and rebase is needed.