More specific Python error mapping #114
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’d like to improve thrown errors. Ideally our tests would make sure that
__getitem__
always raisesIndexError
TypeError
ValueError
RuntimeError
sFor this, I think
.map_py_err
should be the more common API that we use on known error types that we can cleanly map to Python error types, and.map_py_err_from_str
is the (intentionally more verbose) variant inline mapping ofIndexError
occurs due to some runtime issue and should become aRuntimeError
in that case (like a catch-and-reraise)