-
Notifications
You must be signed in to change notification settings - Fork 12
Support debug/flutter adapter, update Zed dependencies #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Tested on: |
@Dixzz I'd like to take over working on this |
Align the name of adapter with standards
@aikins01 @dario-valles
|
Is there any ETA for this PR? 👀👀 |
I tested now on Zed 0.197.3 I can't say that it works for me. Plain dart as well as flutter apps do not start up [
{
"label": "Debug Flutter App",
"adapter": "dart",
"type": "flutter",
"program": "lib/main.dart",
"args": ["--web-port=9090"]
},
{
"adapter": "dart",
"type": "dart",
"label": "Launch Dart App",
"program": "lib/plain.dart",
"stopOnEntry": false
}
] Am I missing something? |
Any updates on this |
Confirmed this PR is functional on Zed 0.198.5 when the following is added to
Please note the device was set to How much testing to we need to undertake to get this merged? |
I guess I should compile a few readme improvements...I'll push those shortly. |
Please provide:Logs of flutter doctor |
I can confirm the same issue as @fstof, I can see the debug targets but spawning them does nothing. ![]()
On 801b322 for this extension (dart) and Flutter version 3.32.8
EDIT: Can confirm it does work with the correct adapter name 😅
|
Thank you @vleeuwenmenno I've updated the same |
I can also confirm the capitalisation fixed it Thanks [EDIT] |
One more crucial thing i think is missing here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes worked for me... Use it... or don't
Thank you for working on this. We all really appreciate it
"description": "Path to the Dart file to debug", | ||
"examples": ["lib/main.dart", "bin/main.dart", "test/example_test.dart"] | ||
}, | ||
"args": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the cwd
property
"cwd": {
"type": "string",
"description": "Path to the working directory"
},
.get("platform") | ||
.and_then(|v| v.as_str()) | ||
.unwrap_or("web"); | ||
let cwd = Some(worktree.root_path()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updating the cwd
to use the user configured one
let cwd = user_config
.get("cwd")
.and_then(|v| v.as_str())
.map(|s| s.to_string())
.or_else(|| Some(worktree.root_path()));
I tried it, works on mac with "Dart" as adapter name, but with said lint warning. |
@Dixzz using macOS here, this is amazing! Can't wait for this to be merged even with a minimum feature-set. We (the community) can help and improve on it gradually. |
@Dixzz is there something blocking the PR? Is it awaited for QA or maybe somebody from the zed team needs to be mentioned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Dixzz is there anything you'd like to follow up with?
🧩 Summary
This PR integrates Dart Debug Adapter Protocol (DAP) support into
zed-extensions/dart
, allowing interactive debugging sessions directly within Zed viadart debug_adapter
IMPORTANT
Make sure you have: in project path
.zed/debug.json
Steps shown:
Debug Flutter App
task in Zed usingF4
or command palletdebugger: start
main.dart
📸 Screenshots
All supported schema for
.zed/debug.json
config