fix: add overrides for comment (and string) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why these are needed, but many other languages have them, and extending doc/block comments on newline doesn't work without them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for extending doc comments on newline has changed since we merged #27, and Zed now requires that languages have a
@comment.inclusiveoverride for that feature to work. This change adds such an override for PHP comments, and also for(string)as well, because that seems to be a common override in other lang extensions.Caveat: I don't understand the relevance of these overrides, and this is very much a "me copy code here. make problem fix gud" sort of fix. 😄 I have read the relevant docs at https://zed.dev/docs/extensions/languages#syntax-overrides but still don't quite see the relevance in this context. But it works. Please correct me if I'm wrong! 😄
Repro: With latest version installed, opening this snippet w/ cursor at
^and pressing enter will insert a new, blank line, but with this PR, it will insert a line starting with*as expected.cc @smitbarmase for input/comment on if this config is incorrect