fix: use strict-weak ordering for message to sign

[lumtis]

Summary by CodeRabbit

• Bug Fixes
  • Improved the sorting logic for signing messages to ensure a more accurate and consistent order.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change updates the comparison logic in the sorting function for message hashes within the KeySign method. The comparison now uses a strictly greater-than condition, affecting how equal hash values are ordered during sorting. No other logic, error handling, or exported declarations are modified.

Changes

File(s)	Change Summary
tss/keysign.go	Modified the sorting comparison for message hashes to use strict "greater-than" instead of "greater-than-or-equal".

Sequence Diagram(s)

No sequence diagram is generated as the change is limited to internal sorting logic and does not affect control flow or component interactions.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de5f121 and 7905d20.

📒 Files selected for processing (1)

• tss/keysign.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: lint
• GitHub Check: test go 1.22
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

tss/keysign.go (1)

293-306: Critical fix: Proper strict weak ordering implementation for message sorting.

This change correctly implements strict weak ordering by using > instead of >= in the comparison function. The previous implementation violated the irreflexivity property (an element should not compare as "less than" itself), which could lead to undefined sorting behavior.

In the context of TSS (Threshold Signature Scheme), deterministic and consistent message ordering is critical for security and correctness across all participating nodes. This fix ensures that:

1. Equal hash values are handled correctly without violating sort comparison semantics
2. The sorting behavior is predictable and consistent across different Go runtime versions
3. All nodes will produce identical message orderings, which is essential for the TSS protocol

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.