Skip to content

Support Shizuku alongside Sui #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkusTieger
Copy link

Not a large change, but both Sui and Shizuku use the Shizuku-Api.

Currently Material Files only supports Sui.
Shizuku seems to be more maintained than sui. Shizuku supports root as well as rootless (Sui only with root).

This pr adds a small change, that allows Shizuku to be used as well.

@MarkusTieger
Copy link
Author

Fixes #1274

@MarkusTieger
Copy link
Author

First of all, thank you for your interest in help improving this project! However, I normally won't accept PRs for this project because I'm currently the only copyright owner for it (except for translations and maybe my company), which I think would be a nice thing to keep along. On the other hand, forcing people to give up their copyright to me is both awkward and legally-complex. So if you have any suggestions for an improvement, please feel free to comment on existing issues or open a new one!

@zhanghai If it is required for this pr to be merged, you can have the copyright.

Copy link

@adambog-comiks adambog-comiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/src/main/AndroidManifest.xml

@@ -33,7 +33,7 @@
<uses-permission android:name="com.android.launcher.permission.INSTALL_SHORTCUT" />

<!-- Shizuku requires API 23. -->
<uses-sdk tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared" />
<uses-sdk tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared,rikka.shizuku.provider" />

<!--
~ Samsung DeX requires explicitly setting android:resizeableActivity="true" for the app to be

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools:overrideLibrary="rikka.shizuku.aidl,rikka.shizuku.api,rikka.shizuku.shared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants