spirv: refactor and remove deduplication ISel #24661
Merged
+8,302
−12,059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alichraghi
force-pushed
the
spv4
branch
3 times, most recently
from
6d14ced to
00a146f
Compare
|
wow! |
alexrp
reviewed
Aug 3, 2025
alexrp
reviewed
Aug 3, 2025
before this we would get a crash
andrewrk
requested changes
Aug 8, 2025
Comment on lines
+174
to
+180
| const dir_handle = Os.getDirHandle(gpa, path, &mount_id) catch |err| switch (err) { | ||
| error.FileNotFound => { | ||
| std.debug.assert(w.dir_table.swapRemove(path)); | ||
| continue; | ||
| }, | ||
| else => return err, | ||
| }; |
There was a problem hiding this comment.
sorry, but can you please do this separately?
andrewrk
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiling behavior tests time is now cut by at least %90