Add fault edge #360
Open
Add fault edge #360
+46
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-richie-y
force-pushed
the
fault-edge
branch
from
649906b to
d93e068
Compare
RazinShaikh
reviewed
Oct 20, 2025
pyzx/rewrite_rules/basicrules.py
Outdated
| other_vertex = v1 | ||
| if other_vertex == v1 and g.edge_type(e) == EdgeType.SIMPLE: | ||
| continue | ||
| if other_vertex == v1 and g.edge_type(e) == EdgeType.FAULT_EDGE: |
There was a problem hiding this comment.
Just to make sure I understand this line, when fusing two spiders that are connected by a simple edge, if there is a faulty edge between them, this condition prevents the fusion from creating a fault edge self-loop. Is this the intended behaviour?
There was a problem hiding this comment.
Yeah thats not right. Good spot!
y-richie-y
force-pushed
the
fault-edge
branch
from
d93e068 to
8018c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to the discussion in #358, I've added a very basic implementation of fault edges in pyzx which doesn't allow any rewrites. This enables to open a corresponding PR in zxlive.