-
Notifications
You must be signed in to change notification settings - Fork 2.1k
log4jChange - [NO REVIEW] #46602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
log4jChange - [NO REVIEW] #46602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the Maven dependency scope for logging-related libraries in Cosmos Spark connectors from compile
to provided
, indicating these dependencies should be provided by the runtime environment rather than packaged with the library.
- Changes slf4j-api and log4j dependencies from compile to provided scope
- Adds test-scoped logging dependencies to ensure tests can still run
- Affects both fabric-cosmos-spark-auth and azure-cosmos-spark connector modules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
sdk/cosmos/fabric-cosmos-spark-auth_3/pom.xml | Changes slf4j-api dependency scope from compile to provided |
sdk/cosmos/azure-cosmos-spark_3_2-12/pom.xml | Changes multiple logging dependencies to provided scope and adds test-scoped equivalents |
<groupId>org.apache.logging.log4j</groupId> | ||
<artifactId>log4j-core</artifactId> | ||
<version>2.17.2</version> <!-- {x-version-update;org.apache.logging.log4j:log4j-core;external_dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency duplicates the existing log4j-core dependency that was changed to provided scope. Consider consolidating these by removing the duplicate and using a single dependency with appropriate scope management through Maven profiles or other mechanisms.
<groupId>org.apache.logging.log4j</groupId> | |
<artifactId>log4j-core</artifactId> | |
<version>2.17.2</version> <!-- {x-version-update;org.apache.logging.log4j:log4j-core;external_dependency} --> | |
<scope>test</scope> | |
</dependency> | |
<dependency> |
Copilot uses AI. Check for mistakes.
<dependency> | ||
<groupId>org.slf4j</groupId> | ||
<artifactId>slf4j-api</artifactId> | ||
<version>1.7.36</version> <!-- {x-version-update;org.slf4j:slf4j-api;external_dependency} --> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency duplicates the existing slf4j-api dependency that was changed to provided scope. Consider consolidating these dependencies to avoid duplication and potential version conflicts.
<dependency> | |
<groupId>org.slf4j</groupId> | |
<artifactId>slf4j-api</artifactId> | |
<version>1.7.36</version> <!-- {x-version-update;org.slf4j:slf4j-api;external_dependency} --> | |
<scope>test</scope> | |
</dependency> | |
<dependency> | |
<dependency> |
Copilot uses AI. Check for mistakes.
No description provided.