-
Notifications
You must be signed in to change notification settings - Fork 2.1k
log4jChange - [NO REVIEW] #46602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xinlian12
wants to merge
1
commit into
Azure:main
Choose a base branch
from
xinlian12:fabricAuthLog4j
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
log4jChange - [NO REVIEW] #46602
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -137,6 +137,7 @@ | |||||||||||||||||||
| <groupId>org.apache.logging.log4j</groupId> | ||||||||||||||||||||
| <artifactId>log4j-core</artifactId> | ||||||||||||||||||||
| <version>2.17.2</version> <!-- {x-version-update;org.apache.logging.log4j:log4j-core;external_dependency} --> | ||||||||||||||||||||
| <scope>provided</scope> | ||||||||||||||||||||
| </dependency> | ||||||||||||||||||||
| <dependency> | ||||||||||||||||||||
| <groupId>io.opentelemetry</groupId> | ||||||||||||||||||||
|
|
@@ -165,6 +166,30 @@ | |||||||||||||||||||
| </dependency> | ||||||||||||||||||||
|
|
||||||||||||||||||||
| <!-- Test --> | ||||||||||||||||||||
| <dependency> | ||||||||||||||||||||
| <groupId>org.apache.logging.log4j</groupId> | ||||||||||||||||||||
| <artifactId>log4j-core</artifactId> | ||||||||||||||||||||
| <version>2.17.2</version> <!-- {x-version-update;org.apache.logging.log4j:log4j-core;external_dependency} --> | ||||||||||||||||||||
| <scope>test</scope> | ||||||||||||||||||||
| </dependency> | ||||||||||||||||||||
| <dependency> | ||||||||||||||||||||
| <groupId>org.slf4j</groupId> | ||||||||||||||||||||
| <artifactId>slf4j-api</artifactId> | ||||||||||||||||||||
| <version>1.7.36</version> <!-- {x-version-update;org.slf4j:slf4j-api;external_dependency} --> | ||||||||||||||||||||
| <scope>test</scope> | ||||||||||||||||||||
| </dependency> | ||||||||||||||||||||
| <dependency> | ||||||||||||||||||||
|
Comment on lines
+175
to
+181
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This dependency duplicates the existing slf4j-api dependency that was changed to provided scope. Consider consolidating these dependencies to avoid duplication and potential version conflicts.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||||||||||||
| <groupId>org.apache.logging.log4j</groupId> | ||||||||||||||||||||
| <artifactId>log4j-slf4j-impl</artifactId> | ||||||||||||||||||||
| <version>2.17.2</version> <!-- {x-version-update;org.apache.logging.log4j:log4j-slf4j-impl;external_dependency} --> | ||||||||||||||||||||
| <scope>test</scope> | ||||||||||||||||||||
| <exclusions> | ||||||||||||||||||||
| <exclusion> | ||||||||||||||||||||
| <groupId>org.slf4j</groupId> | ||||||||||||||||||||
| <artifactId>*</artifactId> | ||||||||||||||||||||
| </exclusion> | ||||||||||||||||||||
| </exclusions> | ||||||||||||||||||||
| </dependency> | ||||||||||||||||||||
| <dependency> | ||||||||||||||||||||
| <groupId>com.globalmentor</groupId> | ||||||||||||||||||||
| <artifactId>hadoop-bare-naked-local-fs</artifactId> | ||||||||||||||||||||
|
|
@@ -236,13 +261,13 @@ | |||||||||||||||||||
| <groupId>org.slf4j</groupId> | ||||||||||||||||||||
| <artifactId>slf4j-api</artifactId> | ||||||||||||||||||||
| <version>1.7.36</version> <!-- {x-version-update;org.slf4j:slf4j-api;external_dependency} --> | ||||||||||||||||||||
| <scope>compile</scope> | ||||||||||||||||||||
| <scope>provided</scope> | ||||||||||||||||||||
| </dependency> | ||||||||||||||||||||
| <dependency> | ||||||||||||||||||||
| <groupId>org.apache.logging.log4j</groupId> | ||||||||||||||||||||
| <artifactId>log4j-slf4j-impl</artifactId> | ||||||||||||||||||||
| <version>2.17.2</version> <!-- {x-version-update;org.apache.logging.log4j:log4j-slf4j-impl;external_dependency} --> | ||||||||||||||||||||
| <scope>compile</scope> | ||||||||||||||||||||
| <scope>provided</scope> | ||||||||||||||||||||
| <exclusions> | ||||||||||||||||||||
| <exclusion> | ||||||||||||||||||||
| <groupId>org.slf4j</groupId> | ||||||||||||||||||||
|
|
||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency duplicates the existing log4j-core dependency that was changed to provided scope. Consider consolidating these by removing the duplicate and using a single dependency with appropriate scope management through Maven profiles or other mechanisms.
Copilot uses AI. Check for mistakes.