Skip to content

Polar plot method #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #179

moved polar plot method from LadybugTools_Toolkit to here. Also added ability to view the summed totals of values for use with plotting anything other than wind roses (for instance a radiation rose would be more useful to show total radiation from a direction, rather than the probability it happens), implemented through the density bool.

The implementation is necessarily different to how it works in LBT (due to not being linked to a dataset through the Wind class), so data is input as a dataframe, and the method reads the values and directions columns specified.

Removed other_data as an input, as now that was a workaround for the Wind class to create roses from data that was not in the wind object itself (basically moving the polar plot method to Python_Toolkit made it redundant). See the linked LBT PR for more info.

Renamed other_bins to value_bins (as it is easier to tell what it actually means this way)

Test files

run the unit tests in LBT Toolkit
When unit tests for this method are made, run those as well.

Do a spot check with some openmeteo data in jupyter to check that it all works.

Changelog

  • Moved polar plot method to this toolkit from LadybugTools_Toolkit

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Jul 1, 2025
@Tom-Kingstone Tom-Kingstone added status:WIP PR in progress and still in draft, not ready for formal review type:feature New capability or enhancement labels Jul 1, 2025
@Tom-Kingstone Tom-Kingstone requested a review from tg359 July 1, 2025 12:43
@Tom-Kingstone Tom-Kingstone removed the status:WIP PR in progress and still in draft, not ready for formal review label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move PlotWindrose from LBT_TK to Python Toolkit
1 participant