Added unix setExec support, and added timeout on downloads #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2025
IPdotSetAF
reviewed
Aug 5, 2025
YoutubeDLSharp/Utils.cs
Outdated
Comment on lines
246
to
254
| { | ||
| if(OSHelper.IsWindows)return; | ||
| #if NET8_0_OR_GREATER | ||
| if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | ||
| File.SetUnixFileMode(filename, UnixFileMode.UserExecute | UnixFileMode.UserRead | UnixFileMode.UserWrite); | ||
| #else | ||
| throw new PlatformNotSupportedException("Setting Unix permissions is not supported on this platform."); | ||
| #endif | ||
| } |
There was a problem hiding this comment.
- checking with the
OSHelper.GetOSVersion()is probably enough. File.SetUnixFileMode()is available in .NET 7+
IPdotSetAF
reviewed
Aug 5, 2025
YoutubeDLSharp/Utils.cs
Outdated
Comment on lines
193
to
201
| public static async Task DownloadFFmpeg(string directoryPath = "", int timeoutSeconds = 60 * 5) | ||
| { | ||
| await FFDownloader(directoryPath, FFmpegApi.BinaryType.FFmpeg); | ||
| await FFDownloader(directoryPath, binary: FFmpegApi.BinaryType.FFmpeg); | ||
| } | ||
|
|
||
| public static async Task DownloadFFprobe(string directoryPath = "") | ||
| public static async Task DownloadFFprobe(string directoryPath = "", int timeoutSeconds = 60 * 5) | ||
| { | ||
| await FFDownloader(directoryPath, FFmpegApi.BinaryType.FFprobe); | ||
| await FFDownloader(directoryPath, binary:FFmpegApi.BinaryType.FFprobe); | ||
| } |
There was a problem hiding this comment.
timeoutSeconds is not used in these functions
IPdotSetAF
reviewed
Aug 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for timeouts.
Also made unix downloads (.net core 8 or above) set unix permissions