fix: FieldSpeciaficationManager log corrections

[arng40]

This PR aim to correct and update some log introduced with #3658

• An incorrect log was output when we specify an objectpath="ElementRegions" with an invalid fieldName
  Example with one of our test deck

<FieldSpecification
      name="topInitialPressure"
      initialCondition="1"
      setNames="{ top }"
      objectPath="ElementRegions"
      fieldName="pressuree"
      scale="5e6"/>

Currently we have

***** LOCATION: /data/pau901/VDG_GSI/ARNAUDD/geosRepos/codes/GEOS5/src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp:272
***** Controlling expression (should be false): true
***** Rank 0: 
initialPressure/fieldName (simulationA_prop_erreurP.xml, l.326): there are no fieldName named `pressuree` under the region `ElementRegions`.

With the correction

FieldSpecificationManager.cpp:293
***** Controlling expression (should be false): true
***** Rank 0: 
initialPressure/fieldName (simulationA_prop_erreurP.xml, l.326): there are no fieldName named `pressuree` under the region `ElementRegions`.
 ElementRegions contain the following fields : 
 { bcPressure, bcTemperature, compAmount, compAmount_n, componentCFLNumber, componentOutflux, dGlobalCompFraction_dGlobalCompDensity, dPhaseMobility, dPhaseVolumeFraction, deltaPressure, deltaVolume, 
 fluid_phaseCompFraction, fluid_phaseDensity, fluid_phaseFraction, 
 [...] 
rockPorosity_salt_referencePorosity, temperature, temperatureScalingFactor, temperature_n }
There are 5 also CellElementsRegions that can be appended under ElementRegions : Reservoir, Caprock, Overburden, Underburden, Salt.

---

• When we specify a region with no materials :

<FieldSpecification
      name="topInitialPressure"
      initialCondition="1"
      setNames="{ top }"
      objectPath="ElementRegions/Barrier"
      fieldName="pressuree"
      scale="5e6"/>
      ```

Before

***** LOCATION: /data/pau901/VDG_GSI/ARNAUDD/geosRepos/codes/GEOS2/src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp:238
***** Controlling expression (should be false): true
***** Rank 0: 
topInitialPressure/fieldName (deadoil_2ph_staircase_gravity_segregation_3d.xml, l.132): there is no fieldName named `pressure` under the objectPath `ElementRegions/Barrier`.
Available fields in ElementRegions/Barrier are:

Now we got this message

***** LOCATION: /data/pau901/VDG_GSI/ARNAUDD/geosRepos/codes/GEOS5/src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp:293
***** Controlling expression (should be false): true
***** Rank 0: 
topInitialPressure/fieldName (deadoil_2ph_staircase_gravity_segregation_3d.xml, l.132): there are no fieldName named `pressure` under the region `ElementRegions/Barrier`.
No material found under ElementRegions/Barrier.

[dkachuma]

Isn't there already a tokenize method to do this?

[wrtobin]

GEOS/src/coreComponents/common/format/StringUtilities.hpp

Line 155 in 3c8cc72

CONTAINER< string > tokenize( string const & str,

[dkachuma]

I'm not sure about these path manipulations. Feels like something that should be handled by dataRepository. Is it possible to use

template< typename REGIONTYPE = ElementRegionBase, typename ... REGIONTYPES, typename LOOKUP_CONTAINER, typename LAMBDA >
void ElementRegionManager::forElementRegions( LOOKUP_CONTAINER const & targetRegions, LAMBDA && lambda ) const

Or additionally/alternatively the subRegion version of this.

[wrtobin]

GEOS/src/coreComponents/common/format/StringUtilities.hpp

Line 155 in 3c8cc72

CONTAINER< string > tokenize( string const & str,

[wrtobin]

prefer existing tokenize over a redundant implementation, other than that this is fine

[paveltomin]

prefer existing tokenize over a redundant implementation, other than that this is fine

seems resolved