fix: FieldSpeciaficationManager log corrections

src/coreComponents/fieldSpecification/FieldSpecificationManager.cpp

@@ -192,15 +192,6 @@ void FieldSpecificationManager::validateBoundaryConditions( MeshLevel & mesh ) c
     {
       mapEntry.second = MpiWrapper::min( mapEntry.second );
     }
-    bool areAllSetsEmpty = true;
-    for( std::pair< string const, localIndex > & mapEntry : isTargetSetEmpty )
-    {
-      if( mapEntry.second == 0 ) // target set is not empty
-      {
-        areAllSetsEmpty = false;
-        break;
-      }
-    }
 
     for( std::pair< string const, localIndex > & mapEntry : isTargetSetCreated )
     {
@@ -227,7 +218,7 @@ void FieldSpecificationManager::validateBoundaryConditions( MeshLevel & mesh ) c
         missingSetNames.emplace_back( mapEntry.first );
       }
 
-      string setNamesError = GEOS_FMT( "\n{}: there is/are no set(s) named `{}` under the {} `{}`.\n",
+      string setNamesError = GEOS_FMT( "\n{}: there are no set(s) named `{}` under the {} `{}`.\n",
                                        fs.getWrapperDataContext( FieldSpecificationBase::viewKeyStruct::objectPathString() ),
                                        fmt::join( missingSetNames, ", " ),
                                        FieldSpecificationBase::viewKeyStruct::objectPathString(), fs.getObjectPath() );
@@ -249,25 +240,48 @@ void FieldSpecificationManager::validateBoundaryConditions( MeshLevel & mesh ) c
 
     if( isFieldNameFound == 0 )
     {
-      std::ostringstream fieldNameNotFoundMessage;
-      std::string fieldNamePath =
-        GEOS_FMT( "\n{}: there is no {} named `{}` under the region `{}`.\n",
-                  fs.getWrapperDataContext( FieldSpecificationBase::viewKeyStruct::fieldNameString() ),
-                  FieldSpecificationBase::viewKeyStruct::fieldNameString(),
-                  fs.getFieldName(), fs.getObjectPath() );
-
-      fieldNameNotFoundMessage << fieldNamePath;
-      if( areAllSetsEmpty )
+      std::ostringstream errorMessageBuilder;
+      errorMessageBuilder << GEOS_FMT( "\n{}: there are no {} named `{}` under the region `{}`.\n",
+                                       fs.getWrapperDataContext( FieldSpecificationBase::viewKeyStruct::fieldNameString() ),
+                                       FieldSpecificationBase::viewKeyStruct::fieldNameString(),
+                                       fs.getFieldName(), fs.getObjectPath() );;
+
+      string_array const splitPath =  stringutilities::tokenize( fs.getObjectPath(), "/" );
+      string const targetRegion = splitPath.size() > 1 ? splitPath.at( 1 ) : splitPath.at( 0 );
+
+      string_array availableRegions;
+      bool foundMaterialInTargetRegion = false;
+      mesh.getElemManager().forElementRegions< ElementRegionBase >( [&]( ElementRegionBase const & elemRegion )
+      {
+        availableRegions.push_back( elemRegion.getName());
+        if( targetRegion == elemRegion.getName() && !elemRegion.getMaterialList().empty())
+        {
+          errorMessageBuilder << GEOS_FMT( "Available fieldname in {} are:\n{{ {} }}", fs.getObjectPath(),
+                                           stringutilities::join( allPresentFieldsName[invalidRegion], ", " ));
+          foundMaterialInTargetRegion = true;
+        }
+      } );
+
+      if( splitPath.size()==1 )
       {
-        GEOS_LOG_RANK_0( fieldNameNotFoundMessage.str() );
+        std::set< std::string > uniqueFields;
+        for( const auto & pair : allPresentFieldsName )
+        {
+          const auto & vec = pair.second;
+          uniqueFields.insert( vec.begin(), vec.end());
+        }
+        errorMessageBuilder << GEOS_FMT( "{} contain the following fields :\n{{ {} }}\n", fs.getObjectPath(),
+                                         stringutilities::join( uniqueFields, ", " ) );
+        errorMessageBuilder << GEOS_FMT( "There are also {} CellElementsRegions that can be appended under {} : [{}].",
+                                         availableRegions.size(), fs.getObjectPath(),
+                                         stringutilities::join( availableRegions, ", " ) );
       }
-      else
+      else if( !foundMaterialInTargetRegion )
       {
-        fieldNameNotFoundMessage << GEOS_FMT( "Available fields in {} are:\n", fs.getObjectPath() );
-        fieldNameNotFoundMessage << stringutilities::join( allPresentFieldsName[invalidRegion], ", " );
+        errorMessageBuilder << GEOS_FMT( "No material found under {}.\n", fs.getObjectPath() );
+      }
 
-        GEOS_THROW( fieldNameNotFoundMessage.str(), InputError );
-      };
+      GEOS_THROW( errorMessageBuilder.str(), InputError );
     }
   } );
 }