Skip to content

[fivetran] Use nonblocking socket for tokio #31937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Mar 18, 2025

Motivation

Testdrive started failing for me locally due to this Tokio behaviour change: tokio-rs/tokio#7172

I'm unsure why this doesn't fail in CI... maybe a MacOS thing? I believe this is happening locally because I'm running the code in debug mode, and these assertions are debug-only for now. Anyways setting the option makes things work as expected.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@bkirwi bkirwi requested a review from a team as a code owner March 18, 2025 17:41
@bkirwi bkirwi requested a review from ParkMyCar March 18, 2025 17:41
Copy link
Contributor

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bkirwi bkirwi merged commit fd7f80d into MaterializeInc:main Mar 19, 2025
22 checks passed
@ggevay
Copy link
Contributor

ggevay commented Mar 19, 2025

Thanks a lot for the fix, I've just run into this too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants