Skip to content

[fivetran] Use nonblocking socket for tokio #31937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

[fivetran] Use nonblocking socket for tokio #31937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/fivetran-destination/src/bin/mz-fivetran-destination.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ async fn run(Args { port }: Args) -> Result<(), Box<dyn std::error::Error>> {
let socket = Socket::new(Domain::IPV6, Type::STREAM, Some(Protocol::TCP))?;
// Disable Nagle's algorithm, maybe not needed but seems decent to start.
socket.set_nodelay(true)?;
// Now required; see https://github.com/tokio-rs/tokio/issues/7172
socket.set_nonblocking(true)?;
// OpenBSD disables dual-stack, if we need to support OpenBSD we'll have to explicitly create
// two sockets.
//
Expand Down