Skip to content

[Build] Add Protobuf flag to allow MSVC + Bazel #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

tryuan99
Copy link
Member

@tryuan99 tryuan99 commented Jul 15, 2025

As mentioned in #49, this additional flag allows Protobuf to be successfully compiled on Windows.

See https://github.com/PisterLab/micromissiles-unity/actions/runs/16305928163 for a successful Windows build of the plugins.

@tryuan99 tryuan99 requested a review from daniellovell July 15, 2025 23:11
@tryuan99 tryuan99 added the bug Something isn't working label Jul 16, 2025
Copy link
Member

@daniellovell daniellovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Windows machine with

bazel build -c opt //:plugins

Result:

Target //:plugins up-to-date:
  bazel-plugins/bazel-out/x64_windows-opt/bin/plugins.tar.gz
INFO: Elapsed time: 169.599s, Critical Path: 60.76s
INFO: 2118 processes: 835 internal, 1283 local.
INFO: Build completed successfully, 2118 total actions

Ran tests with

bazel test //assignment:all

Passed with result:

INFO: Elapsed time: 66.773s, Critical Path: 19.78s
INFO: 1158 processes: 991 action cache hit, 440 internal, 718 local.
INFO: Build completed successfully, 1158 total actions
//assignment:cover_assignment_test                                       PASSED in 0.2s
//assignment:even_assignment_test                                        PASSED in 0.3s
//assignment:weighted_even_assignment_test                               PASSED in 0.3s

Executed 3 out of 3 tests: 3 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.

LGTM 👍 ship it

@tryuan99 tryuan99 merged commit fe3c930 into master Jul 16, 2025
8 checks passed
@tryuan99 tryuan99 deleted the titan/fix_windows_plugin_build branch July 16, 2025 07:30
@tryuan99 tryuan99 linked an issue Jul 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Windows plugins build
2 participants