Skip to content

Temporary fix: define the footer locally #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025

Conversation

brian-rose
Copy link
Member

Temporary workaround until #530 is resolved.

This PR just defines the footer locally for the portal site, so it will at least display there.

Copy link
Contributor

github-actions bot commented Jun 20, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 7e5416f
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/531

@brian-rose
Copy link
Member Author

The upstream config file https://github.com/ProjectPythia/pythia-config/blob/main/pythia.yml may be incorrectly formatted. I got the footer to display here by moving the parts: definition into the site: section of the yaml.

https://mystmd.org/guide/website-navigation#navigation-footer

@brian-rose brian-rose marked this pull request as ready for review June 20, 2025 18:45
@brian-rose brian-rose requested a review from a team as a code owner June 20, 2025 18:45
@brian-rose brian-rose requested review from dopplershift and erogluorhan and removed request for a team June 20, 2025 18:45
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me for the time being

@brian-rose brian-rose merged commit 2b9b29a into ProjectPythia:main Jun 23, 2025
3 checks passed
@brian-rose brian-rose deleted the temp-footer branch June 23, 2025 19:54
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
jukent pushed a commit to jukent/projectpythia.github.io that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants