Use robot capabilities #3433
Use robot capabilities #3433
Conversation
wmostrenko
requested review from
itsarune,
sauravbanna and
williamckha
as code owners
| required bool robot_0 = 1; | ||
| required bool robot_1 = 2; | ||
| required bool robot_2 = 3; | ||
| required bool robot_3 = 4; | ||
| required bool robot_4 = 5; | ||
| required bool robot_5 = 6; |
There was a problem hiding this comment.
The number of robots will change when we move from div B to div A, so it would be better to consider a more flexible approach. Could we instead use a repeated uint32 field that stores the IDs of the robots that are broken?
There was a problem hiding this comment.
@wmostrenko do you remember what the outcome of this discussion was. I vaguely remember talking about it during software-general
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
|
|
||
| // Object to represent which robots have broken dribblers, kickers, or chippers | ||
| // (updated via Thunderscope) | ||
| required RobotCapabilitiesConfig robot_capabilities_config = 15; |
There was a problem hiding this comment.
there's one of these defined in AiConfig (line 39). You should probably delete one of them :)
4 participants
Please fill out the following before requesting review on this PR
Description
Added the ability to state whether or not certain robots have broken dribblers, kickers, or chippers using checkboxes for each robot id under the Parameters widget in Thunderscope. For instance, if you check the checkbox for Robot 2's dribbler, Robot 2 shouldn't be assigned any tactics that involve dribbling. Also added tests for this functionality, and updated many tactics' required RobotCapabilities.
Testing Done
Added tests in sensor_fusion to check that when the protos used to describe which robots have broken dribblers/kickers/chippers are changed, the specific robot's unavailable capabilities are also changed accordingly. Also observed the correct robot behaviour in Thunderscope.
Resolved Issues
resolved #3371
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue