Add pattern module with stricter transcript recording
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recmo
changed the title
patter module with stricter transcript recordingpattern module with stricter transcript recording
WizardOfMenlo
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Great work! I am happy with it, left a few nits here and there but overall very happy with the structure.
Waiting for @mmaker to have a pass and then happy to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
patternmodule that contains a representation of an interactive interaction pattern together with recording and playback states. The pattern contains types, labels and hierarchical grouping of (sub)protocols.As discussed with @WizardOfMenlo, this only adds the pattern module for review and does not use it anywhere yet. The intention is for a follow up PR to use it as a substitute for
DomainSeparator.