Skip to content

Conversation

delucchi-cmu
Copy link
Contributor

Related to (but does not close) astronomy-commons/hats#550

Requires astronomy-commons/hats#560

  • Adds the properties into a created catalog, when generating a _healpix_29 column.
  • Allows the use of a differently-named spatial index column in the schema, set as the dataframe index, and uses it for crossmatch.
  • Refreshes the unit test data, using the most recent properties.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.19%. Comparing base (5fe1775) to head (586e232).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/loaders/hats/read_hats.py 78.57% 3 Missing ⚠️
src/lsdb/dask/merge_catalog_functions.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
- Coverage   97.34%   97.19%   -0.15%     
==========================================
  Files          46       46              
  Lines        2634     2638       +4     
==========================================
  Hits         2564     2564              
- Misses         70       74       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [883d500] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
25.0±0.4ms 26.0±0.9ms 1.04 benchmarks.time_box_filter_on_partition
586±3ms 589±2ms 1.01 benchmarks.time_open_many_columns_list
884±9ms 884±5ms 1.00 benchmarks.time_create_midsize_catalog
92.5±1ms 92.5±0.6ms 1.00 benchmarks.time_kdtree_crossmatch
1.71±0.04s 1.71±0.03s 1.00 benchmarks.time_open_many_columns_default
43.1±2ms 43.1±1ms 1.00 benchmarks.time_polygon_search
5.93±0.02s 5.86±0.06s 0.99 benchmarks.time_create_large_catalog

Some benchmarks failed or their performance regressed significantly.

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [076269e] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
25.4±0.4ms 25.6±0.4ms 1.01 benchmarks.time_box_filter_on_partition
92.0±1ms 92.7±1ms 1.01 benchmarks.time_kdtree_crossmatch
41.2±1ms 41.8±1ms 1.01 benchmarks.time_polygon_search
5.90±0.01s 5.91±0.01s 1.00 benchmarks.time_create_large_catalog
886±6ms 882±9ms 1.00 benchmarks.time_create_midsize_catalog
591±5ms 589±4ms 1.00 benchmarks.time_open_many_columns_list
1.77±0.01s 1.70±0.06s 0.96 benchmarks.time_open_many_columns_default

Some benchmarks failed or their performance regressed significantly.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left only a couple of questions!

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [52f6c43] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
90.6±2ms 92.4±2ms 1.02 benchmarks.time_kdtree_crossmatch
24.8±0.5ms 25.2±0.4ms 1.01 benchmarks.time_box_filter_on_partition
576±8ms 577±3ms 1.00 benchmarks.time_open_many_columns_list
40.5±0.8ms 40.6±0.6ms 1.00 benchmarks.time_polygon_search
5.89±0.02s 5.79±0s 0.98 benchmarks.time_create_large_catalog
881±10ms 856±2ms 0.97 benchmarks.time_create_midsize_catalog
1.68±0.06s 1.63±0.01s 0.97 benchmarks.time_open_many_columns_default

Some benchmarks failed or their performance regressed significantly.

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [304e9aa] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
25.3±0.4ms 26.2±1ms 1.04 benchmarks.time_box_filter_on_partition
89.8±0.8ms 92.8±3ms 1.03 benchmarks.time_kdtree_crossmatch
5.85±0.03s 5.84±0.03s 1.00 benchmarks.time_create_large_catalog
879±7ms 874±7ms 0.99 benchmarks.time_create_midsize_catalog
584±10ms 574±5ms 0.98 benchmarks.time_open_many_columns_list
1.75±0s 1.68±0.06s 0.96 benchmarks.time_open_many_columns_default
42.9±2ms 39.9±0.3ms 0.93 benchmarks.time_polygon_search

Some benchmarks failed or their performance regressed significantly.

Copy link

github-actions bot commented Oct 7, 2025

Before [5fe1775] After [4784840] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_open_many_columns_all
88.5±0.7ms 88.9±0.4ms 1.00 benchmarks.time_kdtree_crossmatch
1.69±0.07s 1.69±0.05s 1.00 benchmarks.time_open_many_columns_default
39.5±2ms 39.7±0.4ms 1.00 benchmarks.time_polygon_search
25.1±0.5ms 24.9±0.4ms 0.99 benchmarks.time_box_filter_on_partition
5.85±0.04s 5.75±0s 0.98 benchmarks.time_create_large_catalog
869±6ms 855±4ms 0.98 benchmarks.time_create_midsize_catalog
588±9ms 572±5ms 0.97 benchmarks.time_open_many_columns_list

Some benchmarks failed or their performance regressed significantly.

@delucchi-cmu delucchi-cmu merged commit 3aa9fb1 into main Oct 7, 2025
11 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/hats/550 branch October 7, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants