Skip to content

Conversation

B0Y3R-AVA
Copy link
Contributor

@B0Y3R-AVA B0Y3R-AVA commented Aug 28, 2025

… screen when adding a contact

Description

Ticket: CP-11945

Please include a summary of the changes. Please also include relevant motivation and context. List any dependencies that are required for this change. If this is a breaking change, please also include steps to migrate.

Summary of changes

  • Used Global serach params instead of local to recieve data passed back from scanQRCode when adding a contact
  • This is safe as we clear out the params after we set them in the ContactForm

Screenshots/Videos

Please include Screenshots / Videos of iOS and android

ScreenRecording_08-28-2025.10-15-18_1.MP4
Screen.Recording.2025-08-28.at.1.13.32.PM.mov

Testing

  • Manually tested with both physical iOS / Android devices as seen above in the videos

Dev Testing Steps

Please include steps for testing happy path of your feature, and be sure to move this ticket into the "Dev Testing" column

Android: https://app.bitrise.io/app/7d7ca5af7066e290/installable-artifacts/052e885eded29db5/public-install-page/f2f5c4fd3c451b8cd8381e1328cd5052
ios: testflight build 5952

  1. Add a new contact
  2. For each address choose "Scan QR code" for entering contacts addresses per chain
  3. Scan QR code and see us return to AddContact Screen with filled out address

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have included screenshots / videos of android and ios
  • I have added Dev testing steps
  • I have added/updated necessary unit tests
  • I have updated the documentation

@B0Y3R-AVA B0Y3R-AVA changed the title used global search params to recieve data passed back from scanQrCode… CP-11945: Fix ScanQRCode to add contact Aug 28, 2025
@B0Y3R-AVA B0Y3R-AVA merged commit c21b885 into main Aug 28, 2025
4 checks passed
@B0Y3R-AVA B0Y3R-AVA deleted the boyer/CP-11945 branch August 28, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants