Skip to content

CP-11945: Fix ScanQRCode to add contact #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

CP-11945: Fix ScanQRCode to add contact #3184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/core-mobile/app/new/features/accountSettings/components/ContactForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from 'common/utils/alertWithTextInput'
import { isValidContactName } from 'common/utils/isValidContactName'
import { loadAvatar } from 'common/utils/loadAvatar'
import { useFocusEffect, useLocalSearchParams, useRouter } from 'expo-router'
import { useFocusEffect, useGlobalSearchParams, useRouter } from 'expo-router'
import React, { useCallback, useMemo, useRef } from 'react'
import { Contact } from 'store/addressBook'
import { useSelector } from 'react-redux'
Expand Down Expand Up @@ -213,7 +213,7 @@ const ContactFormField = ({
}): React.ReactNode => {
const isDeveloperMode = useSelector(selectIsDeveloperMode)
const { theme } = useTheme()
const params = useLocalSearchParams<{
const params = useGlobalSearchParams<{
address: string
addressType: AddressType
}>()
Expand Down Expand Up @@ -252,6 +252,7 @@ const ContactFormField = ({
onUpdateAddress(params.addressType, params.address)
ref.current?.setInputValue(params.address)
// @ts-ignore TODO: make route params typesafe
// Clear params immediately after use to prevent pollution
setParams({ address: undefined, addressType: undefined })
}
}, [
Expand Down
Loading