Skip to content

Fix logger.error usage in basename utilities #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix logger.error usage in basename utilities #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55921a4
Fix logger.error usage in basename utilities
ramGit22 Oct 7, 2025
c6f9d4d
Merge pull request #1 from ramGit22/fix logger.error usage
ramGit22 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/web/src/utils/redirectIfNameDoesNotExist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ export async function redirectIfNameDoesNotExist(username: Basename) {
getBasenameOwner(username),
]);
} catch (error) {
logger.error('Error fetching basename address, editor, or owner', {
error,
logger.error('Error fetching basename address, editor, or owner', error, {
username,
});
apiError = true;
Expand Down
6 changes: 2 additions & 4 deletions apps/web/src/utils/usernames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,7 @@ export async function getBasenameNameExpires(username: Basename) {

return nameExpires;
} catch (error) {
logger.error('Error fetching basename expiration date', {
error,
logger.error('Error fetching basename expiration date', error, {
username,
tokenId,
chainId: chain.id,
Expand Down Expand Up @@ -851,8 +850,7 @@ export async function isBasenameInGracePeriod(username: Basename): Promise<boole
// Name is in grace period if it's expired but within the grace period duration
return timeSinceExpiration > 0 && timeSinceExpiration <= GRACE_PERIOD_DURATION_MS;
} catch (error) {
logger.error('Error checking if basename is in grace period', {
error,
logger.error('Error checking if basename is in grace period', error, {
username,
});
return false;
Expand Down