Skip to content

Rename animation to gltf_animation #21388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

Rename animation to gltf_animation #21388

merged 2 commits into from
Oct 6, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Oct 4, 2025

Objective

Solution

  • Do a rename

Testing

  • Ran some examples

@atlv24 atlv24 added S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Animation Make things move and change over time labels Oct 4, 2025
JMS55
JMS55 reviewed Oct 6, 2025
View reviewed changes
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 6, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 6, 2025
Merged via the queue into bevyengine:main with commit ff7837e Oct 6, 2025
46 checks passed
tigregalis pushed a commit to tigregalis/bevy that referenced this pull request Oct 7, 2025
@atlv24 @tigregalis
Rename animation to gltf_animation (bevyengine#21388)
bdd436e 
# Objective

- Step towards bevyengine#20867

## Solution

- Do a rename

## Testing

- Ran some examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@JMS55 JMS55 JMS55 left review comments

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atlv24 @alice-i-cecile @IceSentry @JMS55