-
Notifications
You must be signed in to change notification settings - Fork 33
feat: generate specific tools for operations #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
blurrah
wants to merge
13
commits into
main
Choose a base branch
from
schema-generated-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the wrong way to tackle this as it just performs worse than the simpler implementation currently in use. It adds way too many tools and also creates complex input schema's which just lead to models having a hard time to work with this. Nice eye opener that I shouldn't overengineer this |
Reopening as I want to offer this as an alternative to just querying the complete schema |
See issue #4, should've allowed this from the start
cffcc73
to
3391568
Compare
While the shorthand McpServer is nice, it's not as nice to use for dynamic tool generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for specific tools based on operations in the schema. This is an alternative to just querying the schema completely, especially if your schema exceeds context windows.
Need to think on how to craft this API a bit more, possibly re-add arguments as you can just stack in operations