Skip to content

Conversation

acupoftee
Copy link

@acupoftee acupoftee commented Sep 27, 2019

This PR addresses Issue #22

  • My approach for this iteration was to add an alert for large JSON files. This would be good feedback for the user when trying to parse JSON.
  if ( bodyChildren.length !== 1 || pre.tagName !== 'PRE' ||  jsonLength > (3000000)) {
        if (jsonLength) {
            alert('JSON Formatter Error: Cannot format JSON longer than 3MB');
        }
        // Disconnect the port (without even having used it)
          port.disconnect() ;
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant