Skip to content

Add Alert for JSON Files Larger than 3MB #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Alert for JSON Files Larger than 3MB #149

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bd362b
Add alert for formatting errors
acupoftee Sep 27, 2019
4ceb2a2
Move length check to separate if statement
acupoftee Sep 27, 2019
88b5702
Refactored length check
acupoftee Sep 28, 2019
d7b94da
Revert if check
acupoftee Sep 28, 2019
0753176
Revert "Revert if check"
acupoftee Sep 28, 2019
88680e3
Refactor length check
acupoftee Sep 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions extension/js/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,12 +220,12 @@
var jsonLength = (pre && pre.innerText || "").length ;
if (
bodyChildren.length !== 1 ||
pre.tagName !== 'PRE' ||
jsonLength > (3000000) ) {

pre.tagName !== 'PRE' || jsonLength > (3000000)) {
// console.log('Not even text (or longer than 3MB); exiting') ;
// console.log(bodyChildren.length,pre.tagName, pre.innerText.length) ;

if (jsonLength) {
alert('JSON Formatter Error: Cannot format JSON longer than 3MB');
}
// Disconnect the port (without even having used it)
port.disconnect() ;

Expand Down