Add option for disabling unclean leader election #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its disabled by default here, in effort to be idiomatic, as it will be disabled in newer versions of kafka by default too. (from `0.11.0.0`)
|
Also, you should look into using Sigil (https://github.com/gliderlabs/sigil) for server config templating. Its much nicer than going through sed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its disabled by default here, in effort to be idiomatic, as it will be
disabled in newer versions of kafka by default too. (from
0.11.0.0)Let me know what you think, and if you need help backporting it to older tags (I'm interested in the v0.10.0.1 tag myself)
Btw, this is a fantastic repository. A while ago I tried to achieve a similar thing: getting kafka to run on a single docker host. You've kept this updated, and in pristine condition. 👍 good work!