Skip to content

Add option for disabling unclean leader election #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option for disabling unclean leader election #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ with their default values, if any:
will create the path in ZK automatically; with earlier versions, you must
ensure it is created before starting brokers.

- `KAFKA_UNCLEAN_LEADER_ELECTION=(true|false)`, Default here: `false`
Favour availability over consistency by allowing a non-ISR replica to become
a leader for a partition, possibly losing writes. Disabled by default from
version `0.11.0.0`

JMX
---

Expand Down
1 change: 1 addition & 0 deletions config/server.properties.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,6 @@ inter.broker.protocol.version={{KAFKA_INTER_BROKER_PROTOCOL_VERSION}}
log.message.format.version={{KAFKA_LOG_MESSAGE_FORMAT_VERSION}}
message.max.bytes={{KAFKA_MESSAGE_MAX_BYTES}}
replica.fetch.max.bytes={{KAFKA_REPLICA_FETCH_MAX_BYTES}}
unclean.leader.election.enable={{KAFKA_UNCLEAN_LEADER_ELECTION}}

# vim:set filetype=jproperties
1 change: 1 addition & 0 deletions start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ cat /kafka/config/server.properties.template | sed \
-e "s|{{ZOOKEEPER_SESSION_TIMEOUT_MS}}|${ZOOKEEPER_SESSION_TIMEOUT_MS:-10000}|g" \
-e "s|{{KAFKA_MESSAGE_MAX_BYTES}}|${KAFKA_MESSAGE_MAX_BYTES:-1000012}|g" \
-e "s|{{KAFKA_REPLICA_FETCH_MAX_BYTES}}|${KAFKA_REPLICA_FETCH_MAX_BYTES:-1048576}|g" \
-e "s|{{KAFKA_UNCLEAN_LEADER_ELECTION}}|${KAFKA_UNCLEAN_LEADER_ELECTION:-false}|g" \
> /kafka/config/server.properties

# Kafka's built-in start scripts set the first three system properties here, but
Expand Down