Drivetrains #82
Drivetrains #82
Conversation
roni-kreinin
requested review from
civerachb-cpr and
luis-camero
and removed request for
a team
| # Individual motor protection states | ||
| uint8[] motor_states | ||
| clearpath_motor_msgs/LynxMotorProtection[] motor_states |
There was a problem hiding this comment.
Given recent discussions about trying to avoid changing the messages as much as possible, are we sure we want to make this change here & apply it to Jazzy, or would it be safer/easier to defer this particular change for the next distro and keep Jazzy as-is?
If we hadn't already released support for all the platforms I'd be fine with this, but changing this message definition is going to require rebuilding & updating firmware on every platform, won't it?
It looks like a good change, and it should definitely be included in a future release. But I'm not 100% sure we want to make this change right now.
I'm happy to be overruled on this point, I'm just hesitant about message changes if we don't absolutely need them.
There was a problem hiding this comment.
Only clearpath_platform_msgs changes affect firmware. clearpath_motor_msgs are only used on the PC
Multi repo PR: