test: refactor TestNetworkInspect in network_inspect_test.go #4310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @haytok Do you think we could also have a test for |
apostasie
approved these changes
Jun 9, 2025
Based on the following three pieces of advice received in the merged PR, this commit refactors the tests. - containerd#4309 (comment) - containerd#4309 (comment) - containerd#4309 (comment) Signed-off-by: Hayato Kiwata <[email protected]>
Suppose that a `container A` is running in the network `some-network-as-well`. In this case, this commit adds a test to ensure that `container A` isn't displayed in the `Containers` section of the output of `nerdctl network inspect some-network`. Signed-off-by: Hayato Kiwata <[email protected]>
haytok
force-pushed
the
refactor_network_inspect_test.go
branch
from
e3780ff to
fee517a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the following three pieces of advice received in the merged PR, this commit refactors the tests.
Also, this PR adds one test case to TestNetworkInspect based on this comment.