Skip to content

test: refactor TestNetworkInspect in network_inspect_test.go #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

test: refactor TestNetworkInspect in network_inspect_test.go #4310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3086d71
test: refactor TestNetworkInspect in network_inspect_test.go
haytok Jun 8, 2025
fee517a
test: add one test case to TestNetworkInspect in network_inspect_test.go
haytok Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 37 additions & 14 deletions cmd/nerdctl/network/network_inspect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"github.com/containerd/nerdctl/mod/tigron/expect"
"github.com/containerd/nerdctl/mod/tigron/require"
"github.com/containerd/nerdctl/mod/tigron/test"
"github.com/containerd/nerdctl/mod/tigron/tig"

"github.com/containerd/nerdctl/v2/pkg/inspecttypes/dockercompat"
"github.com/containerd/nerdctl/v2/pkg/testutil"
Expand Down Expand Up @@ -323,33 +324,55 @@ func TestNetworkInspect(t *testing.T) {
{
Description: "Display containers belonging to multiple networks in the output of nerdctl network inspect",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("network", "create", data.Identifier("nginx-network-1"))
helpers.Ensure("network", "create", data.Identifier("nginx-network-2"))
helpers.Ensure("network", "create", data.Identifier("network-1"))
helpers.Ensure("network", "create", data.Identifier("network-2"))

helpers.Ensure("run", "-d", "--name", data.Identifier(), "--network", data.Identifier("nginx-network-1"), "--network", data.Identifier("nginx-network-2"), testutil.NginxAlpineImage)
containerID := helpers.Capture("run", "-d", "--name", data.Identifier(), "--network", data.Identifier("network-1"), "--network", data.Identifier("network-2"), testutil.CommonImage, "sleep", nerdtest.Infinity)

data.Labels().Set("containerID", strings.Trim(helpers.Capture("inspect", data.Identifier(), "--format", "{{.Id}}"), "\n"))
data.Labels().Set("containerID", strings.Trim(containerID, "\n"))
},
Cleanup: func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rm", "-f", data.Identifier())
helpers.Anyhow("network", "remove", data.Identifier("nginx-network-1"))
helpers.Anyhow("network", "remove", data.Identifier("nginx-network-2"))
helpers.Anyhow("network", "remove", data.Identifier("network-1"))
helpers.Anyhow("network", "remove", data.Identifier("network-2"))
},
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
return helpers.Command("network", "inspect", data.Identifier("nginx-network-1"))
return helpers.Command("network", "inspect", data.Identifier("network-1"))
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
return &test.Expected{
Output: func(stdout string, info string, t *testing.T) {
var dc []dockercompat.Network
err := json.Unmarshal([]byte(stdout), &dc)

assert.NilError(t, err, "Unable to unmarshal output\n"+info)
Output: expect.JSON([]dockercompat.Network{}, func(dc []dockercompat.Network, info string, t tig.T) {
assert.Equal(t, 1, len(dc), "Unexpectedly got multiple results\n"+info)
assert.Equal(t, dc[0].Name, data.Identifier("nginx-network-1"))
assert.Equal(t, dc[0].Name, data.Identifier("network-1"))
assert.Equal(t, 1, len(dc[0].Containers), "Expected a single container as per configuration, but got multiple.")
assert.Equal(t, data.Identifier(), dc[0].Containers[data.Labels().Get("containerID")].Name)
},
}),
}
},
},
{
Description: "Display only containers attached to the specific network",
Setup: func(data test.Data, helpers test.Helpers) {
helpers.Ensure("network", "create", data.Identifier("some-network"))
helpers.Ensure("network", "create", data.Identifier("some-network-as-well"))

helpers.Ensure("run", "-d", "--name", data.Identifier(), "--network", data.Identifier("some-network-as-well"), testutil.CommonImage, "sleep", nerdtest.Infinity)
},
Cleanup: func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rm", "-f", data.Identifier())
helpers.Anyhow("network", "remove", data.Identifier("some-network"))
helpers.Anyhow("network", "remove", data.Identifier("some-network-as-well"))
},
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
return helpers.Command("network", "inspect", data.Identifier("some-network"))
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
return &test.Expected{
Output: expect.JSON([]dockercompat.Network{}, func(dc []dockercompat.Network, info string, t tig.T) {
assert.Equal(t, 1, len(dc), "Unexpectedly got multiple results\n"+info)
assert.Equal(t, dc[0].Name, data.Identifier("some-network"))
assert.Equal(t, 0, len(dc[0].Containers), "Expected no containers as per configuration, but got multiple.")
}),
}
},
},
Expand Down
Loading