This repository was archived by the owner on Aug 29, 2022. It is now read-only.
Default SYNC_PREFER=newer #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly EugenMayer's docker-sync has decided to prefer the host: EugenMayer/docker-sync#108 |
|
I clarified this in the other issue, but just to restate it here: the sync is not unidirectional by default. Unison syncs in both directions, and if it's not, something else is wrong. Also, the current default is to prefer $SYNC_SOURCE for conflict resolutions, which should be the host FS (as in eugenmayer's docker-sync). |
|
@cweagans I guess this makes this PR unnecessary then. The problem then must be something else I guess. |
|
I think |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems confusing for some folks (and me) that after the initial sync the ongoing sync is only unidirectional (container to host only). Let's make it bidirectional by default. Refs #2