Subscription copy changes for duck.ai and plans #6383
Merged
+206
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cmonfortep
force-pushed
the
feature/cristian/subscriptions/duck_ai_ppro_rename
branch
from
1e2b12e to
b7522e5
Compare
nalcalag
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
You'd need to remove this change and do it in another PR so we trigger translations job.
nalcalag
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Question: Why are you pre-fetching the value and caching it, instead of simply checking if the toggle is enabled in the API implementation? Is this a pattern we should follow if a view depends on it?
There was a problem hiding this comment.
Accessing Toggle.isEnabled produces an IO operation which should happen in a IO thread. In some places I can't perform that operation in the background, so I'm using this main-thread safe method.
cmonfortep
merged commit 7b6d60a
into
feature/cristian/subscriptions/show_duck_ai_pro_settings
27 of 28 checks passed
cmonfortep
deleted the
feature/cristian/subscriptions/duck_ai_ppro_rename
branch
cmonfortep
added a commit
that referenced
this pull request
Jul 14, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1149059203486286/task/1210704593867822?focus=true ### Description Updates copies/icons/visuals to integrate with duck.ai changes ### Steps to test this PR _Feature 1_ - [x] Apply latest staging patch from this task https://app.asana.com/1/137249556945/project/1209991789468715/task/1210448620621729?focus=true - [x] Fresh install - [x] Go to settings - [x] In the subscription section validate the copies are the ones in "NEW" column in https://app.asana.com/1/137249556945/project/1149059203486286/task/1210704593867822?focus=true - [x] Purchase the subscription - [x] Ensure "New" pill appears in Duck.ai - [x] Go to settings -> send feedback - [x] Ensure we say "subscription" according to https://app.asana.com/1/137249556945/project/1149059203486286/task/1210704593867822?focus=true (last table) _Feature 2_ - [x] Cancel and remove your subscription - [x] Go to Feature flags inventory - [x] Disable privacypro - duckaiplus - [x] Go to the browser - [x] Access settings again (you need to enter so it re-evaluates the FF) - [x] Ensure you don't see ai models in the subscription section (description field) - [x] The title mentions privacy pro _Feature 3_ - [x] Cancel and remove your subscription (if any) - [x] Go to Feature flags inventory - [x] Disable privacypro - subscriptionRebranding - [x] Restart the browser (we need to restart the process since value is cached) - [x] Navigate to settings - [x] Ensure you see privacy pro copies ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1149059203486286/task/1210704593867822?focus=true
Description
Updates copies/icons/visuals to integrate with duck.ai changes
Steps to test this PR
Feature 1
Feature 2
Feature 3
UI changes