Subscription copy changes for duck.ai and plans #6383
+206
−16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright (c) 2025 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.subscriptions.api | ||
|
|
||
| interface SubscriptionRebrandingFeatureToggle { | ||
| /** | ||
| * This method is safe to call from the main thread. | ||
| * @return true if the subscription rebranding feature is enabled, false otherwise | ||
| */ | ||
| fun isSubscriptionRebrandingEnabled(): Boolean | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Copyright (c) 2025 DuckDuckGo | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.duckduckgo.subscriptions.impl | ||
|
|
||
| import androidx.lifecycle.LifecycleOwner | ||
| import com.duckduckgo.app.di.AppCoroutineScope | ||
| import com.duckduckgo.app.lifecycle.MainProcessLifecycleObserver | ||
| import com.duckduckgo.common.utils.DispatcherProvider | ||
| import com.duckduckgo.di.scopes.AppScope | ||
| import com.duckduckgo.privacy.config.api.PrivacyConfigCallbackPlugin | ||
| import com.duckduckgo.subscriptions.api.SubscriptionRebrandingFeatureToggle | ||
| import com.squareup.anvil.annotations.ContributesBinding | ||
| import com.squareup.anvil.annotations.ContributesMultibinding | ||
| import dagger.SingleInstanceIn | ||
| import javax.inject.Inject | ||
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.launch | ||
| import logcat.logcat | ||
|
|
||
| @ContributesBinding( | ||
| scope = AppScope::class, | ||
| boundType = SubscriptionRebrandingFeatureToggle::class, | ||
| ) | ||
| @ContributesMultibinding( | ||
| scope = AppScope::class, | ||
| boundType = PrivacyConfigCallbackPlugin::class, | ||
| ) | ||
| @ContributesMultibinding( | ||
| scope = AppScope::class, | ||
| boundType = MainProcessLifecycleObserver::class, | ||
| ) | ||
| @SingleInstanceIn(AppScope::class) | ||
| class SubscriptionRebrandingFeatureToggleImpl @Inject constructor( | ||
| private val privacyProFeature: PrivacyProFeature, | ||
| @AppCoroutineScope private val appCoroutineScope: CoroutineScope, | ||
| private val dispatcherProvider: DispatcherProvider, | ||
| ) : SubscriptionRebrandingFeatureToggle, PrivacyConfigCallbackPlugin, MainProcessLifecycleObserver { | ||
|
|
||
| private var cachedValue: Boolean = false | ||
|
|
||
| override fun isSubscriptionRebrandingEnabled(): Boolean { | ||
| return cachedValue | ||
| } | ||
|
|
||
| override fun onCreate(owner: LifecycleOwner) { | ||
| super.onCreate(owner) | ||
| logcat { "SubscriptionRebrandingFeatureToggle: App created, prefetching feature flag" } | ||
| prefetchFeatureFlag() | ||
| } | ||
|
|
||
| override fun onPrivacyConfigDownloaded() { | ||
| logcat { "SubscriptionRebrandingFeatureToggle: Privacy config downloaded, refreshing feature flag" } | ||
| prefetchFeatureFlag() | ||
| } | ||
|
|
||
| private fun prefetchFeatureFlag() { | ||
| appCoroutineScope.launch(dispatcherProvider.io()) { | ||
| val isEnabled = privacyProFeature.subscriptionRebranding().isEnabled() | ||
| cachedValue = isEnabled | ||
| logcat { "SubscriptionRebrandingFeatureToggle: Feature flag cached, value = $isEnabled" } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. You'd need to remove this change and do it in another PR so we trigger translations job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Why are you pre-fetching the value and caching it, instead of simply checking if the toggle is enabled in the API implementation? Is this a pattern we should follow if a view depends on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing
Toggle.isEnabledproduces an IO operation which should happen in a IO thread. In some places I can't perform that operation in the background, so I'm using this main-thread safe method.