Add index block removal API #4684
Conversation
|
Following you can find the validation changes for the APIs you have modified.
You can validate these APIs yourself by using the |
It's breaking but avoids duplicating the type names, which is forbidden.
pquentin
requested review from
flobernd and
l-trotta
and removed request for
pquentin
| } | ||
| } | ||
|
|
||
| export class IndicesBlockStatus { | ||
| export class AddIndicesBlockStatus { |
There was a problem hiding this comment.
Thinking about future API extensions: If there is the chance for a get_index_block_status endpoint in the future, it would probably make sense to have this type in the _types namespace.
There was a problem hiding this comment.
I don't think that's super relevant, as an API like that will always return which type of block exists on the index, rather than just a boolean.
specification/indices/remove_block/examples/response/IndicesAddBlockResponseExample1.yaml
Outdated
Show resolved
Hide resolved
| * @rest_spec_name indices.remove_block | ||
| * @availability stack since=9.1.0 stability=stable | ||
| * @availability serverless stability=stable visibility=public | ||
| * @doc_id index-block-remove |
There was a problem hiding this comment.
Are there any index_privileges or cluster_privileges we need to specify? these will show up in the docs.
There was a problem hiding this comment.
Good question, I'm not familiar with privileges myself, so I'll ask around.
There was a problem hiding this comment.
I added the manage index privilege. We'll have to add it to IndicesAddBlockRequest as well, but I'll do that in a follow-up PR.
|
@pquentin I'm not sure how to resolve the conflicts with |
* Add index block removal API Follow-up of elastic/elasticsearch#129128 * Fix block enum * Add doc-id to table * Fix lint * Move IndicesBlockOptions and IndicesBlockStatus to indices/_types It's breaking but avoids duplicating the type names, which is forbidden. * Separate BlockStatus as it is different * Rename response example file * Fix response fields * Add index privilege --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit e668a98)
* Add index block removal API Follow-up of elastic/elasticsearch#129128 * Fix block enum * Add doc-id to table * Fix lint * Move IndicesBlockOptions and IndicesBlockStatus to indices/_types It's breaking but avoids duplicating the type names, which is forbidden. * Separate BlockStatus as it is different * Rename response example file * Fix response fields * Add index privilege --------- (cherry picked from commit e668a98) Co-authored-by: Niels Bauman <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
Follow-up of elastic/elasticsearch#129128