-
Notifications
You must be signed in to change notification settings - Fork 91
Achinth Tripathi Legal documentation - Threshold, MTA - Merging Legacy Threshold/MTA with Threshold/MTA. Updated attributes, conditions, and definitions. #4048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Achinth Tripathi Legal documentation - Threshold, MTA - Merging Legacy Threshold/MTA with Threshold/MTA. Updated attributes, conditions, and definitions. #4048
Conversation
…ith Threshold/MTA. Updated attributes, conditions, and definitions.
Legal documentation - Threshold, MTA - Merging Legacy Threshold/MTA with Threshold/MTA. Updated attributes, conditions, and definitions.Background D2LT and ISDA are working to enhance the legal documentation aspect of CDM. D2LT has reviewed the IM/VM and Legacy Credit Support documentation and is updating the model to accurately represent the clauses. This includes the elimination of duplications in the model. What is being released?
Review Directions Changes can be reviewed in PR: #4048 Note This comment was generated via Rosetta. |
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rosetta-source/src/main/rosetta/legaldocumentation-csa-type.rosetta
Outdated
Show resolved
Hide resolved
|
What is being released? Updating as per Oscar's comments. Note This comment was generated via Rosetta. |
rosetta-source/src/main/rosetta/legaldocumentation-csa-type.rosetta
Outdated
Show resolved
Hide resolved
rosetta-source/src/main/rosetta/legaldocumentation-csa-type.rosetta
Outdated
Show resolved
Hide resolved
|
What is being released? Updating as per Oscar's comments. New type ThresholdMTABase to hold common attributes. Note This comment was generated via Rosetta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main suggestion really is not to use an abbreviation for Minimum Transfer Amount as this creates ambiguity. I think there are some other types prefixed MTA which have not been updated in this PR but should be updated to expand the name too.
| partyElection ThresholdType (0..2) <"The party specific election for the threshold clause."> | ||
|
|
||
| type ThresholdType: <"Details whether the threshold is rating based, a fixed amount, or infinity."> | ||
| type ThresholdMTABase: <"A logical container designed to hold a set of related data. In this case, designed to hold a set of information required to specify conditions under which Threshold or Minimum Transfer Amount can fall to zero."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the name will be longer but abbreviations lead to ambiguity so could this be changed to ThresholdMinimumTransferAmountBase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
| partyElection MTATypeElection (0..2) <"The party specific elections for the Minimum Transfer Amount clause."> | ||
|
|
||
| type MTAType: <"Details whether the Minimum Transfer Amount is rating based, a fixed amount, or infinity."> | ||
| type MTATypeElection: <"Specifies the method by which the minimum transfer amount is defined, such as a fixed amount, ratings based, or an alternative basis set out in the agreement."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comment, MTA is ambiguous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
| condition MTAOneOf: <"Ensures that Minimum Transfer Amount is specified as one-of fixedAmount, ratingsBased, or other."> | ||
| required choice fixedAmount, ratingsBased, other | ||
|
|
||
| type MTAFixedAmount extends ThresholdMTABase: <"Defines that the Minimum Transfer Amount (MTA) is a Fixed Amount."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again on MTA = MinimumTransferAmount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
| required choice fixedAmount, ratingsBased, other | ||
|
|
||
| type MTAFixedAmount extends ThresholdMTABase: <"Defines that the Minimum Transfer Amount (MTA) is a Fixed Amount."> | ||
| minimumTransferAmount Money (1..1) <"Specifies the monetary value of the Minimum Transfer Amount applicable to collateral transfer obligations."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as we're in a type named Minimum Transfer Fixed Amount do we need to prefix this attribute with "minimumTransfer-"? Could we just call it amount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
| type MTAFixedAmount extends ThresholdMTABase: <"Defines that the Minimum Transfer Amount (MTA) is a Fixed Amount."> | ||
| minimumTransferAmount Money (1..1) <"Specifies the monetary value of the Minimum Transfer Amount applicable to collateral transfer obligations."> | ||
|
|
||
| type MTARatingsBased extends ThresholdMTABase: <"Defines that the Minimum Transfer Amount (MTA) is based on a Ratings condition(s)."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MinimumTransferAmountRatingsBased perhaps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
| required choice fixedAmount, ratingsBased, infinity, other | ||
|
|
||
| type ThresholdFixedAmount extends ThresholdMTABase: <"Defines that the Threshold is based on a Fixed Amount."> | ||
| thresholdAmount Money (1..1) <"Specifies the monetary value of the threshold applicable to collateral transfer obligations."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need the "threshold-" prefix? Could it just be amount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
|
What is being released? Updating as per Chris' comments. Note This comment was generated via Rosetta. |
rosetta-source/src/main/rosetta/legaldocumentation-csa-type.rosetta
Outdated
Show resolved
Hide resolved
rosetta-source/src/main/rosetta/legaldocumentation-csa-type.rosetta
Outdated
Show resolved
Hide resolved
rosetta-source/src/main/rosetta/legaldocumentation-csa-type.rosetta
Outdated
Show resolved
Hide resolved
|
What is being released? Updating as per comments. Note This comment was generated via Rosetta. |
|
In the release PR can you update the Threshold Java mapper to look for in the release PR can you update the MinimumTransferAmount Java mapper to look for |
No description provided.