-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
deps: bump node to v22.16.0 #93080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
deps: bump node to v22.16.0 #93080
Conversation
@joshuarli what is the process for updating the mirror and shasum? I've updated the shasum to match the files available from node, but I'm currently getting a 404 from our mirror |
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've updated this PR to use .node-version!
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93080 +/- ##
===========================================
+ Coverage 52.96% 87.26% +34.30%
===========================================
Files 10278 10331 +53
Lines 592704 593213 +509
Branches 23026 22956 -70
===========================================
+ Hits 313919 517691 +203772
+ Misses 278353 75086 -203267
- Partials 432 436 +4 |
I'm working on the CI failures—just a resolution issue with a node-style specifier in the rspack config. |
Unfortunately had to roll Node back because v24.x does not start active LTS until Bumping from v22.11.0 to v22.16.0 will unlock |
sounds good - i'll update our mirrors |
vercel doesn't matter tbh. but fine either way |
oh nvm i get it, vercel would need the unflagged transpile. got it |
True! Just being cautious of the official guidance since bugs on Current releases aren't unheard of.
And yeah, Vercel doesn't expose v24 yet for that reason. |
v24 is the new LTS https://nodejs.org/en/blog/release/v24.0.0v22 is still LTS until
2025-10-28
getsentry: https://github.com/getsentry/getsentry/pull/17678