Skip to content

deps: bump node to v22.16.0 #93080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

deps: bump node to v22.16.0 #93080

wants to merge 15 commits into from

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 6, 2025

@JonasBa JonasBa requested review from a team as code owners June 6, 2025 22:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@JonasBa JonasBa requested a review from a team June 6, 2025 22:27
@JonasBa
Copy link
Member Author

JonasBa commented Jun 6, 2025

@joshuarli what is the process for updating the mirror and shasum? I've updated the shasum to match the files available from node, but I'm currently getting a 404 from our mirror

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 11, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've updated this PR to use .node-version!

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93080       +/-   ##
===========================================
+ Coverage   52.96%   87.26%   +34.30%     
===========================================
  Files       10278    10331       +53     
  Lines      592704   593213      +509     
  Branches    23026    22956       -70     
===========================================
+ Hits       313919   517691   +203772     
+ Misses     278353    75086   -203267     
- Partials      432      436        +4     

@natemoo-re
Copy link
Member

I'm working on the CI failures—just a resolution issue with a node-style specifier in the rspack config.

@natemoo-re
Copy link
Member

Unfortunately had to roll Node back because v24.x does not start active LTS until 2025-10-28. Vercel only supports active LTS (which is the correct thing to do, of course).

Bumping from v22.11.0 to v22.16.0 will unlock require(esm) without a flag, which is what we need for some upcoming rspack dependencies to work.

@natemoo-re natemoo-re changed the title deps: bump node to v24 deps: bump node to v22.16.0 Jun 11, 2025
@joshuarli
Copy link
Member

Unfortunately had to roll Node back because v24.x does not start active LTS until 2025-10-28. Vercel only supports active LTS (which is the correct thing to do, of course).

Bumping from v22.11.0 to v22.16.0 will unlock require(esm) without a flag, which is what we need for some upcoming rspack dependencies to work.

sounds good - i'll update our mirrors

@scttcper
Copy link
Member

scttcper commented Jun 11, 2025

vercel doesn't matter tbh. but fine either way

@scttcper
Copy link
Member

oh nvm i get it, vercel would need the unflagged transpile. got it

@natemoo-re
Copy link
Member

natemoo-re commented Jun 11, 2025

True! Just being cautious of the official guidance since bugs on Current releases aren't unheard of.

Production applications should only use Active LTS or Maintenance LTS releases.

And yeah, Vercel doesn't expose v24 yet for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants