Skip to content

deps: bump node to v22.16.0 #93080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .envrc
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ if [ "${SENTRY_DEVENV_SKIP_FRONTEND}" != "1" ]; then
die "You don't seem to have node installed. Please run devenv sync."
fi

if ! node -pe "process.exit(Number(!(process.version == 'v' + require('./.volta.json').volta.node )))"; then
read -r node_version < .node-version
if [ "v${node_version}" != "$(node --version)" ]; then
die "Unexpected $(command -v node) version. Please run devenv sync."
fi

Expand Down
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ eslint.config.mjs @getsentry/owners-js-bu
jest.config.ts @getsentry/owners-js-build
tsconfig.* @getsentry/owners-js-build
webpack.config.* @getsentry/owners-js-build
.volta.json @getsentry/owners-js-deps
.node-version @getsentry/owners-js-deps
package.json @getsentry/owners-js-deps
pnpm-lock.yaml @getsentry/owners-js-deps

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -93,7 +93,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -59,7 +59,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand All @@ -86,7 +86,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -95,7 +95,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand All @@ -122,7 +122,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -131,7 +131,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -184,7 +184,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/jest-balance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -25,7 +25,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/openapi-diff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/openapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
if: steps.changes.outputs.api_docs == 'true'
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -65,7 +65,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-node-modules-${{ hashFiles('pnpm-lock.yaml', 'api-docs/pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/self-hosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand All @@ -63,7 +63,7 @@ jobs:
id: nodemodulescache
with:
path: node_modules
key: ${{ runner.os }}-self-hosted-node-modules-${{ hashFiles('pnpm-lock.yaml', '.volta.json') }}
key: ${{ runner.os }}-self-hosted-node-modules-${{ hashFiles('pnpm-lock.yaml', '.node-version') }}

- name: Install Javascript Dependencies
if: steps.nodemodulescache.outputs.cache-hit != 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
id: setup-node
with:
node-version-file: '.volta.json'
node-version-file: '.node-version'

- uses: pnpm/action-setup@36de12bed180fa130ed56a35e7344f2fa7a820ab # v4

Expand Down
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22.16.0
5 changes: 0 additions & 5 deletions .volta.json

This file was deleted.

1 change: 1 addition & 0 deletions api-docs/.node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22.16.0
5 changes: 0 additions & 5 deletions api-docs/.volta.json

This file was deleted.

12 changes: 1 addition & 11 deletions config/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,5 @@
]
},
"include": ["../static/app", "../static/gsApp", "../tests/js"],
"exclude": ["../node_modules", "../**/*.benchmark.ts"],
"ts-node": {
"transpileOnly": true,
"compilerOptions": {
// TODO: We should be able to use "node16" on next major version of jest
// https://github.com/jestjs/jest/pull/14739
"module": "commonjs",
// TODO: node10 will be deprecated in typescript 6.0
"moduleResolution": "node10"
}
}
"exclude": ["../node_modules", "../**/*.benchmark.ts"]
}
17 changes: 9 additions & 8 deletions devenv/config.ini
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,16 @@ linux_arm64 = https://github.com/indygreg/python-build-standalone/releases/downl
linux_arm64_sha256 = d37aef7bdf5c27f7d006918f7cedb31f4ba07c88f61baac4ffbe0bee6d4b5248

[node]
# upstream (https://nodejs.org/dist/) is not reliable enough so we've mirrored it to GCS
darwin_x86_64 = https://storage.googleapis.com/sentry-dev-infra-assets/node/node-v22.11.0-darwin-x64.tar.xz
darwin_x86_64_sha256 = ab28d1784625d151e3f608a9412a009118f376118ed842ae643f8c2efdfb0af6
darwin_arm64 = https://storage.googleapis.com/sentry-dev-infra-assets/node/node-v22.11.0-darwin-arm64.tar.xz
darwin_arm64_sha256 = c379a90c6aa605b74042a233ddcda4247b347ba5732007d280e44422cc8f9ecb
linux_x86_64 = https://storage.googleapis.com/sentry-dev-infra-assets/node/node-v22.11.0-linux-x64.tar.xz
linux_x86_64_sha256 = 83bf07dd343002a26211cf1fcd46a9d9534219aad42ee02847816940bf610a72
# upstream (https://nodejs.org/dist/) is not reliable enough
# ask someone in team-devinfra to upload for you
darwin_x86_64 = https://storage.googleapis.com/sentry-dev-infra-assets/node/node-v22.16.0-darwin-x64.tar.xz
darwin_x86_64_sha256 = 5c34638f2c0e3f3aaa7b3a94b58304765a169730da1896ebba8515ea4d987a9c
darwin_arm64 = https://storage.googleapis.com/sentry-dev-infra-assets/node/node-v22.16.0-darwin-arm64.tar.xz
darwin_arm64_sha256 = aaf7fc3c936f1b359bc312b63638e41f258689ac2303966ad932cda18c54ea00
linux_x86_64 = https://storage.googleapis.com/sentry-dev-infra-assets/node/node-v22.16.0-linux-x64.tar.xz
linux_x86_64_sha256 = f4cb75bb036f0d0eddf6b79d9596df1aaab9ddccd6a20bf489be5abe9467e84e
# used for autoupdate
version = v22.11.0
version = v22.16.0

# kept here only for compatibility with older `devenv`
[python]
Expand Down
4 changes: 4 additions & 0 deletions devenv/sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ def main(context: dict[str, str]) -> int:
),
{
"NODE_ENV": "development",
# this ensures interactive prompts are answered by
# the defaults (usually yes), useful for recreating
# node_modules if configuration or node version changes
"CI": "true",
},
),
),
Expand Down
2 changes: 2 additions & 0 deletions knip.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import type {KnipConfig} from 'knip';
const productionEntryPoints = [
// the main entry points - app, gsAdmin & gsApp
'static/app/index.tsx',
// chartcuterie build script
'config/build-chartcuterie.ts',
// dynamic imports _not_ recognized by knip
'static/app/bootstrap/{index,initializeMain}.tsx',
'static/gsApp/initializeBundleMetrics.tsx',
Expand Down
13 changes: 5 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -264,12 +264,12 @@
"build-deprecated-docs": "pnpm run install-api-docs && node --experimental-transform-types api-docs/index.ts api-docs/openapi.json tests/apidocs/openapi-deprecated.json",
"diff-docs": "pnpm run install-api-docs && node --experimental-transform-types api-docs/openapi-diff.ts",
"deref-api-docs": "node --experimental-transform-types api-docs/index.ts tests/apidocs/openapi-spectacular.json tests/apidocs/openapi-derefed.json",
"build-chartcuterie-config": "node --experimental-strip-types config/build-chartcuterie.ts",
"build-acceptance": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production rspack",
"build-production": "NODE_ENV=production rspack --mode production",
"build": "NODE_OPTIONS=--max-old-space-size=4096 rspack",
"build-chartcuterie-config": "node --experimental-transform-types config/build-chartcuterie.ts",
"build-acceptance": "CODECOV_ENABLE_BA=false IS_ACCEPTANCE_TEST=1 NODE_ENV=production pnpm run build",
"build-production": "NODE_OPTIONS='--experimental-transform-types' NODE_ENV=production rspack --mode production --config ./rspack.config.ts",
"build": "NODE_OPTIONS='--max-old-space-size=4096 --experimental-transform-types' rspack --config ./rspack.config.ts",
"build-js-loader": "node --experimental-transform-types scripts/build-js-loader.ts",
"build-js-po": "node --experimental-strip-types build-utils/ts-extract-gettext.ts",
"build-js-po": "node --experimental-transform-types build-utils/ts-extract-gettext.ts",
"validate-api-examples": "pnpm run --dir api-docs openapi-examples-validator ../tests/apidocs/openapi-derefed.json --no-additional-properties",
"mkcert-localhost": "mkcert -key-file config/localhost-key.pem -cert-file config/localhost.pem localhost 127.0.0.1 dev.getsentry.net *.dev.getsentry.net && mkcert -install",
"https-proxy": "caddy run --config - <<< '{\"apps\":{\"http\":{\"servers\":{\"srv0\":{\"listen\":[\":8003\"],\"routes\":[{\"handle\":[{\"handler\":\"reverse_proxy\",\"upstreams\":[{\"dial\":\"localhost:8000\"}]}]}],\"tls_connection_policies\":[{\"certificate_selection\":{\"any_tag\":[\"cert0\"]}}]}}},\"tls\":{\"certificates\":{\"load_files\":[{\"certificate\":\"./config/localhost.pem\",\"key\":\"./config/localhost-key.pem\",\"tags\":[\"cert0\"]}]}}}}'",
Expand All @@ -296,9 +296,6 @@
]
},
"packageManager": "[email protected]",
"volta": {
"extends": ".volta.json"
},
"prettier": {
"bracketSpacing": false,
"bracketSameLine": false,
Expand Down
Loading
Loading