Skip to content

ref(feedback): remove legacy event schema from test schema validation #97453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Aug 8, 2025

Removing this since legacy schema will always fail due to the logentry field we add in fix_for_issue_platform.

@aliu39 aliu39 requested a review from a team as a code owner August 8, 2025 00:14
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sentry/feedback/usecases/ingest/create_feedback.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #97453   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files        8557     8557           
  Lines      376461   376458    -3     
  Branches    24468    24468           
=======================================
+ Hits       303369   303378    +9     
+ Misses      72722    72710   -12     
  Partials      370      370           

@aliu39 aliu39 merged commit 41ed0a8 into master Aug 8, 2025
67 checks passed
@aliu39 aliu39 deleted the aliu/rm-legacy-validation branch August 8, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants