Skip to content

ref(feedback): remove legacy event schema from test schema validation #97453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

ref(feedback): remove legacy event schema from test schema validation #97453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/sentry/feedback/usecases/ingest/create_feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
)
from sentry.issues.grouptype import FeedbackGroup
from sentry.issues.issue_occurrence import IssueEvidence, IssueOccurrence
from sentry.issues.json_schemas import EVENT_PAYLOAD_SCHEMA, LEGACY_EVENT_PAYLOAD_SCHEMA
from sentry.issues.json_schemas import EVENT_PAYLOAD_SCHEMA
from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
from sentry.issues.status_change_message import StatusChangeMessage
from sentry.models.group import GroupStatus
Expand Down Expand Up @@ -165,11 +165,8 @@ def validate_issue_platform_event_schema(event_data):
try:
jsonschema.validate(event_data, EVENT_PAYLOAD_SCHEMA)
except jsonschema.exceptions.ValidationError:
try:
jsonschema.validate(event_data, LEGACY_EVENT_PAYLOAD_SCHEMA)
except jsonschema.exceptions.ValidationError:
metrics.incr("feedback.create_feedback_issue.invalid_schema")
raise
metrics.incr("feedback.create_feedback_issue.invalid_schema")
raise


def should_filter_feedback(event: dict) -> tuple[bool, str | None]:
Expand Down
Loading